Music: update small footer styling #52955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Nice, thanks for adding this! Having a dark mode version of this footer is handy and can be potentially used in other labs as well. I'm curious to get @levadadenys's take on this from a rebrand perspective as well, though looks like we are using the new brand colors already.
| /* Custom styling for the locale & copyright buttons and the copyright flyout, | ||
| * for Music Lab. | ||
| */ | ||
| .music-black { |
There was a problem hiding this comment.
Is there a more generic CSS class we could use here? I feel like this dark mode footer will be very useful (for example, this would be great to have on Javalab)
There was a problem hiding this comment.
I was thinking about this too. I'm a bit apprehensive to name something generically before it's actually used generically, so maybe once the next lab uses this, it can do the rename?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the small footer styling for Music Lab.
Updated footer
With copyright flyout open