-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecated Method for Collecting CloudWatch Metrics #54367
Remove Deprecated Method for Collecting CloudWatch Metrics #54367
Conversation
The CloudWatch monitoring scripts are deprecated in favor of the CloudWatch agent, which we started using with #32110 - https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-scripts-intro.html
Looks like we need to update the CloudWatch Alarm to reference the new Metric Namespace and Name here https://github.com/code-dot-org/code-dot-org/blob/4f457167cdd18d84306452a87af0ba084fe43fdc/aws/cloudformation/components/alarms.yml.erb#L29C1-L30 |
Great, thank you! Looks like there's also a reference in
|
…ics to instead reference CloudWatch-Agent-collected metrics
MetricName: MemoryUtilization | ||
Namespace: 'System/Linux' | ||
MetricName: mem_used_percent | ||
Namespace: CWAgent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to change the TreatMissingData
property below to breaching
so that we act on missing data with more urgency https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudwatch-alarm.html#cfn-cloudwatch-alarm-treatmissingdata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable; I'll do so in a follow-up PR, though, since that's unrelated to the metrics switch in this PR
The CloudWatch monitoring scripts are deprecated in favor of the CloudWatch agent, which we started using with #32110
Links
Follow-up work
We may still have dashboards that are referencing the old
System/Linux/MemoryUtilization
metrics; those should be updated to useCWAgent/mem_used_percent