-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let teacher request ai eval #54375
Let teacher request ai eval #54375
Conversation
…itted or already evaluated
…et-teacher-request-ai-eval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests look great Bethany, thank you so much for pitching in! LGTM on changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on Bethany's changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I'm definitely appreciative of these good tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for thinking through this so deeply!
Finishes https://codedotorg.atlassian.net/browse/AITT-101. This PR does the following:
/rubrics/1/ai_evaluation_status_for_user
endpoint, which returns boolean status variables for whether the student hasattempted
the current level, and whether that attempt has been evaluated (lastAttemptEvaluated
).attempted
is computed by looking for presence of a UserLevellastAttemptEvaluated
is computed by comparinguser_level.updated_at
to theupdate_at
timestamp on the most recentLearningGoalAIEvaluation
/rubrics/1/run_ai_evaluation_for_user
to reject the request unless the level has been attempted but not yet evaluatedKudos to Bethany for adding the UI messages and writing the JS tests!
state transition diagram
Here is how the client state behaves in response to the AI evaluation status and user clicks (apologies, I left out EVALUATION PENDING which happens after the run ai button is clicked):
demo
this screen capture shows the following states: INITIAL_LOAD (very brief) --> NOT_ATTEMPTED --> student attempts --> teacher refreshes --> INITIAL_LOAD --> READY --> teacher clicks run --> EVALUATION_PENDING --> SUCCESS
run-ai-button-720p.mov
Testing story