Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable yourschool.feature test #54429

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Re-enable yourschool.feature test #54429

merged 1 commit into from
Oct 24, 2023

Conversation

TurnerRiley
Copy link
Contributor

@TurnerRiley TurnerRiley commented Oct 23, 2023 •
edited

While working on the /yourschool map, I saw that one of the UI tests was skipped for back when the map was broken on production. It's been a while since then and the map is working again so this PR undoes the skipping.

Links

Jira ticket: here

Testing story

Passing drone.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@TurnerRiley TurnerRiley changed the title dont skip test Re-enable yourschool.feature test Oct 24, 2023
@TurnerRiley TurnerRiley requested a review from a team October 24, 2023 17:41
hannahbergam
hannahbergam approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We love to see testing come back:)

@TurnerRiley TurnerRiley merged commit faa4c25 into staging Oct 24, 2023
2 checks passed
@TurnerRiley TurnerRiley deleted the reinstate-yourschool-feature-tests branch October 24, 2023 18:23
TurnerRiley added a commit that referenced this pull request Oct 24, 2023
@TurnerRiley
Revert "dont skip test (#54429)"
d0782d3 
This reverts commit faa4c25.
TurnerRiley added a commit that referenced this pull request Oct 24, 2023
@TurnerRiley
Revert "dont skip test (#54429)" (#54455)
babddec 
This reverts commit faa4c25.
@TurnerRiley TurnerRiley mentioned this pull request Oct 25, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahbergam hannahbergam hannahbergam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TurnerRiley @hannahbergam