Revert "Simplify DCDO Cache Expiration Logic" #54445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 537fad5.
Hamms
added a commit
that referenced
this pull request
Oct 24, 2023
Hamms
added a commit
that referenced
this pull request
Oct 25, 2023
* Revert "Revert "Simplify DCDO Cache Expiration Logic (#53833)" (#54445)" This reverts commit 124e28a. * Return Early from DCDO Get if No Key Set In our previous implementation, we'd never attempt to invoke `.get` directly on the datastore for keys that hadn't ever been set; we just used `.all` to collect everything that was set and put in all in the cache, then tried to get values off the cache. With the new implementation, we will actually check the datastore for values. This means that any key that hasn't had an explicit value set will attempt to load a `nil` value from the datastore, which right now for the JSON-backed and in-memory datastores will also log an error in Honeybadger. Instead, we simply check for the existence of the key in the datastore before trying to parse it as JSON. Note that this is already how it works for the DynamoDB-backed datastore used in production; see [this comparable line](https://github.com/code-dot-org/code-dot-org/blob/02f7d6ea7a50454b7304ff81024ff211b81bd13d/lib/dynamic_config/adapters/dynamodb_adapter.rb#L22) in that version of the adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53833; this caused a bunch of
TypeError: Nil is not a valid JSON source.errors on staging: https://app.honeybadger.io/projects/3240/faults/101613548