Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Blockly] Modal Function Editor UI Fixes #54450

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

molly-moen
Copy link
Contributor

2 small fixes to the modal function editor:

  • remove width: 100% on the toolbar (delete/close buttons) as this was preventing click on part of the definition block.
  • Change the delete button to be purple rather than white. We are adding a modal soon to confirm delete, and these colors are in line with the existing CDO Blockly colors

New Button Color

Screenshot 2023-10-24 at 12 52 36 PM

Links

Testing story

Tested locally

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team October 24, 2023 19:55
@molly-moen molly-moen merged commit d24666a into staging Oct 24, 2023
2 checks passed
@molly-moen molly-moen deleted the molly/mfe-editable-name-description branch October 24, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants