Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the squished piskel editor space bug #54451

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Oct 24, 2023

Updates our repo to use code-dot-org/piskel#59 which fixes the squished piskel editor space bug. See that PR for details

Note: I'm noticing as I hand-test this for correctness, that our code-dot-org repo automatically overrides the default view so new piskel editors are always 100x100 pixels, effectively ignoring the "Default value" setting. It does this by rendering the default view and then immediately overwriting it with a 100x100 view, or whichever user-created image is first on the list. This can be traced by placing a breakpoint in the code where a new frame is created. This is called twice - once when the default view is rendered (where the error was being thrown) and once when the overwriting view is rendered.

We should consider whether we want to overwrite the default view even when there is no user-created image. However, that is a follow-up discussion. For now, pulling in the updates from the piskel repo is sufficient to fix the squished editor bug and prevent the user from getting into an unrecoverable state.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik jmkulwik requested a review from a team October 24, 2023 20:18
@jmkulwik jmkulwik merged commit a392f77 into staging Oct 25, 2023
2 checks passed
@jmkulwik jmkulwik deleted the jmkulwik/squished-animation-fix branch October 25, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants