Fix the squished piskel editor space bug #54451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our repo to use code-dot-org/piskel#59 which fixes the squished piskel editor space bug. See that PR for details
Note: I'm noticing as I hand-test this for correctness, that our code-dot-org repo automatically overrides the default view so new piskel editors are always 100x100 pixels, effectively ignoring the "Default value" setting. It does this by rendering the default view and then immediately overwriting it with a 100x100 view, or whichever user-created image is first on the list. This can be traced by placing a breakpoint in the code where a new frame is created. This is called twice - once when the default view is rendered (where the error was being thrown) and once when the overwriting view is rendered.
We should consider whether we want to overwrite the default view even when there is no user-created image. However, that is a follow-up discussion. For now, pulling in the updates from the piskel repo is sufficient to fix the squished editor bug and prevent the user from getting into an unrecoverable state.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: