Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoc2023: AI naming #54458

Merged
merged 1 commit into from
Oct 24, 2023
Merged

hoc2023: AI naming #54458

merged 1 commit into from
Oct 24, 2023

Conversation

breville
Copy link
Member

@breville breville commented Oct 24, 2023

We are changing the naming of "staging" to "effects". This updates a variety of strings related to that.

Screenshot 2023-10-24 at 4 22 11 PM Screenshot 2023-10-24 at 2 39 26 PM

@breville breville requested review from samantha-code and a team October 24, 2023 21:42
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Is it possible to increase the width of the block so the 'effects' label isn't so close to the edge?

@breville
Copy link
Member Author

Is it possible to increase the width of the block so the 'effects' label isn't so close to the edge?

Good catch. I accidentally posted an older screenshot from when I hand-modified the block. The screenshot is now updated to what's in this PR, which looks better.

@breville breville merged commit 2a88a75 into staging Oct 24, 2023
2 checks passed
@breville breville deleted the hoc2023-ai-naming branch October 24, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants