Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Refactor and Adds Amplitude Event to Email Send Button #54465

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Oct 24, 2023

This PR handles a small refactor (namely, uses a passed through variable for isSignedIn instead of hooking up to current user redux). The translation/text constants are updated accordingly.

Then, it sets up some scaffolding for the send email button, splitting into a function for saving the inputs and sending the email. The email send function will also send the amplitude event, which is now set up!

Screenshot 2023-10-24 at 4 07 01 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam changed the title refactor and add amplitude event Small Refactor and Adds Amplitude Event to Email Send Button Oct 24, 2023
@hannahbergam hannahbergam requested a review from a team October 24, 2023 23:19
Copy link
Contributor

@TurnerRiley TurnerRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a question about the event on Amplitude

AGE_21_SELECTED_EVENT: 'Age 21+ Selected',
GUIDE_SENT_EVENT: 'Guide Sent',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched Amplitude for an event with this name but didn't find one, do we have one set up for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dani!

@hannahbergam hannahbergam merged commit 69877eb into staging Oct 25, 2023
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/component-two-amplitude branch October 25, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants