Fixed not populating invited_by field for coteacher invitations #54467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etaderhold
approved these changes
Oct 25, 2023
| @@ -584,7 +584,7 @@ def update_code_review_expiration(enable_code_review) | |||
| end | |||
| before_validation :strip_emoji_from_name | |||
|
|
|||
| public def add_instructor(email) | |||
| public def add_instructor(email, current_user) | |||
There was a problem hiding this comment.
I think invited_by is a better descriptor of what this parameter is actually for.
Suggested change
| public def add_instructor(email, current_user) | |
| public def add_instructor(email, invited_by) |
Switching it up to keyword parameters instead of positional parameters would make the purpose of passing current_user more clear in the calling sites, at the cost of slightly longer code. I'll leave it up to you whether that's worth it.
Suggested change
| public def add_instructor(email, current_user) | |
| public def add_instructor(email:, invited_by:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
invited_byfield inSectionInstructorwas not being populated correctly because theadd_instructormethod insections.rbwas not able to correctly identify the current_user here. FLUP to this PRThis PR fixes the bug and adds a test that
invited_byis correctly filled out.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: