Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Revert "Simplify DCDO Cache Expiration Logic"" (#54446)" #54497

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Revert "Revert "Revert "Simplify DCDO Cache Expiration Logic"" (#54446)" #54497

merged 1 commit into from
Oct 25, 2023

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Oct 25, 2023

This reverts commit cf57316; the removed after_fork method is actually used in production, and so the invocation of it also needs to be removed

The

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms marked this pull request as ready for review October 25, 2023 21:00
@Hamms Hamms merged commit 6167d9a into staging Oct 25, 2023
1 of 2 checks passed
@Hamms Hamms deleted the revert-54446-revert-54445-revert-53833-threadless-dcdo-cache branch October 25, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Hamms