Check that rubricData exists before pulling it in #54577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobryan0619
changed the title
kobryan0619
commented
Oct 30, 2023
| @@ -667,7 +667,7 @@ class TopInstructions extends Component { | |||
| mapReference || (referenceLinks && referenceLinks.length > 0); | |||
|
|
|||
| const displayHelpTab = | |||
| (levelVideos && levelVideos.length > 0) || levelResourcesAvailable; | |||
| (levelVideos && levelVideos.length > 0) || !!levelResourcesAvailable; | |||
There was a problem hiding this comment.
this changes displayHelpTab to be a boolean value. The only place it is used is as a prop for TopInstructionsHeader which is expecting a boolean.
bethanyaconnor
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got this ZenDesk ticket letting us know that there was an issue with the non-rubric levels looking for data that wasn't there. This PR fixes this by checking that the data exists before pulling it in.
A few other notes:
hasScriptDataso that it followed the same format as thegetScriptData()function. However, when I started to do that, I noticed that in one other place where we usehasScriptData, we use just a "key" as a parameter. This seemed odd to me but I wasn't really sure how to see this in the application and the investigation seemed beyond the scope of this ticket.TopInstructionsHeader. This didn't seem to impact usability, but after a bit of investigation, it seemed like a straightforward fix to stop that from occurring. This is also addressed in this PR.Testing