Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling one test page temporarily #54605

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Oct 31, 2023

Deflaking this test is a WIP in #54533. However, the solution is proving trickier than anticipated.

In the meantime, this test keeps causing hiccups for DOTD, needing to be run upwards of 4 times to pass. This PR temporarily disables what seems to be the biggest culprit.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested a review from a team October 31, 2023 19:25
@hannahbergam hannahbergam changed the title Disabling one test file temporarily Disabling one test page temporarily Oct 31, 2023
@hannahbergam hannahbergam merged commit f86ffcf into staging Oct 31, 2023
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/afe-translations branch October 31, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants