Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hour of Code signup email file name so it matches translation pattern #54607

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

TurnerRiley
Copy link
Contributor

@TurnerRiley TurnerRiley commented Oct 31, 2023

Currently, Mario and I are working on developing a pipeline for pegasus email translations. This email, which will be the first one added to the pipeline once it's ready, ends in "_en" to follow previous years' files but that doesn't match the pattern we should have for sending it into crowdin and getting it translated (which then adds "_[locale code]").

Links

Jira ticket for translation pipeline: here

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@TurnerRiley TurnerRiley requested a review from a team October 31, 2023 20:48
@TurnerRiley TurnerRiley merged commit e744327 into staging Nov 1, 2023
2 checks passed
@TurnerRiley TurnerRiley deleted the update-hoc-signup-file-name branch November 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants