Fix "Save" button on Exemplars not saving #54624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
great find @kobryan0619 ! It took me a minute of staring at your diff to realize what had even changed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I fixed Ken's reported issue of the LevelBuilder "Save" button not working when editing the exemplars in JavaLab.
It is not clear to me how it got broken in the first place though which makes me a bit nervous. I checked the last time any of the impacted files were edited and none of them were less than 4 months ago...
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: