Replace email signature of PD emails #54782
Conversation
|
@dmcavoy tagging you to check that all of these replacements make sense |
| @@ -20,8 +20,8 @@ | |||
| Thank you, | |||
|
|
|||
| %p | |||
| Dave Frye | |||
| Sam Morris | |||
There was a problem hiding this comment.
Lets make this one
Andrea Robertson-Nottingham
Facilitator Network Manager
| @@ -56,9 +56,9 @@ | |||
| Thank you, | |||
| %br | |||
| - if @workshop.course == Pd::Workshop::COURSE_CSF | |||
| Dave Frye | |||
| Sam Morris | |||
There was a problem hiding this comment.
Can we just standardize to the workshop organizers name? Do we have workshops without workshop organizers?
There was a problem hiding this comment.
Checked on production and it doesn't look like it:
[production] dashboard > Pd::Workshop.where(organizer_id: nil).count
=> 0
I can just remove the conditional
There was a problem hiding this comment.
There are workshops where the organizer is nil though -- possibly because the organizer deleted their account or something? Should I do anything about those? We don't really handle it now so I'm leaning no
| @@ -36,6 +36,6 @@ | |||
| %p | |||
| Thank you, | |||
| %br | |||
| Dave Frye | |||
| Sam Morris | |||
There was a problem hiding this comment.
When is this one sent? Based on the name is seems like its sent to facilitators is that right? If so it should come from Andrea
There was a problem hiding this comment.
It's sent in the teacher_enrollment_receipt and teacher_enrollment_reminder emails and in both emails, only when Pd::Workshop::COURSE_FACILITATOR == @workshop.course. So I think it is to facilitators
There was a problem hiding this comment.
Ok then lets have it come from Andrea. Thank you!
| @@ -78,9 +78,9 @@ | |||
| %p | |||
| Thank you, | |||
| %br | |||
| Dave Frye | |||
| Sam Morris | |||
There was a problem hiding this comment.
Lets make this one
Jess Baker
Professional Learning Product Manager
There was a problem hiding this comment.
Actually on second thought make it from the workshop organizer so its more evergreen
| @@ -30,5 +30,5 @@ | |||
| - if @workshop.course == Pd::Workshop::COURSE_CSF | |||
| %p | |||
| Thank you, | |||
| %br Dave Frye | |||
| %br Director of Program Development and Operations, Code.org | |||
| %br Sam Morris | |||
There was a problem hiding this comment.
What happens if someone cancels outside CSF? Do we not say thank you?
This one also seems like it should come from the workshop organizer
There was a problem hiding this comment.
lol I guess not?
There was a problem hiding this comment.
Alright well thats thing we should think about but for now lets make it the workshop organizer
There was a problem hiding this comment.
It reads a little weird here with the workshop organizer
There was a problem hiding this comment.
What if we change it to "If this is a mistake and you did not mean to cancel your workshop registration, please email oscar_organizer@example.net"
| @@ -49,5 +49,5 @@ | |||
|
|
|||
| %p | |||
| Thank you, | |||
| %br Dave Frye | |||
| %br Director of Program Development and Operations, Code.org | |||
| %br Sam Morris | |||
There was a problem hiding this comment.
This one should come from:
Danielle Boulden
K-5 Program Manager
Replace Dave Frye with Sam Morris in email signatures.
I'm not sure if all of these replacements are correct so let me know if someone else should be listed instead.