Add controller for ai evaluation teacher feedback #54830
Conversation
…bs down or on a thumbs up Also pull in the aiInfo object to get the id of the associated AI Evaluation
| @@ -47,6 +47,7 @@ export default function RubricContainer({ | |||
| return response.json(); | |||
| }) | |||
| .then(data => { | |||
| console.log(data); | |||
| HttpClient.post(`${baseUrl}`, bodyData, true, { | ||
| 'Content-Type': 'application/json', | ||
| }).catch(error => { | ||
| console.log(error); |
There was a problem hiding this comment.
If we're not going to do anything with this, it would be better practice to let the js error propagate, so that it shows up in our error reporting.
| HttpClient.post(`${baseUrl}`, bodyData, true, { | ||
| 'Content-Type': 'application/json', | ||
| }).catch(error => { | ||
| console.log(error); |
There was a problem hiding this comment.
per previous comment, please let js error propagate and do not catch it here, unless you are going to catch it and prompt the user to try again
| const icon = require('@cdo/static/ai-bot.png'); | ||
|
|
||
| export default function AiAssessment({ | ||
| isAiAssessed, | ||
| studentName, | ||
| aiUnderstandingLevel, | ||
| aiConfidence, | ||
| learningGoalKey, | ||
| aiInfo, |
There was a problem hiding this comment.
can we please call this aiEval or aiEvalInfo, to make it a bit more specific and to more closely match the name of aiEvaluationShape?
There was a problem hiding this comment.
also, any reason we still need aiUnderstandingLevel and aiConfidence as props, now that we have the aiEvaluation, which contains both of these?
code-dot-org/apps/src/templates/rubrics/rubricShapes.jsx
Lines 45 to 49 in 6c6897e
if not, you could get rid of those props, and do something like this here:
const aiConfidence = aiEval.ai_confidence;
...| const thumbsupval = 'thumbsup'; | ||
| const thumbsdownval = 'thumbsdown'; | ||
| export default function AiAssessmentFeedback({aiInfo}) { | ||
| const radioGroupName = `ai-assessment-feedback-${aiInfo.id}`; |
There was a problem hiding this comment.
this object appears to be of type aiEvaluationShape, but I don't see id defined on that shape. can you please add it here?
code-dot-org/apps/src/templates/rubrics/rubricShapes.jsx
Lines 45 to 49 in 6c6897e
There was a problem hiding this comment.
That's already in this PR!
| const props = { | ||
| learningGoalKey: 'learning_key', | ||
| aiInfo: mock_aiInfo, |
There was a problem hiding this comment.
style nit: please avoid underscores in JS variable names when possible. in this case the variable name can just be mockAiInfo. we try to only use snake_case when it sneaks through in JSON that comes from the server, and even in those cases the better practice is to have the server do the work to convert any key names in JSON to camelCase.
| test_user_gets_response_for :get_by_ai_evaluation_id, params: -> {{learningGoalAiEvaluationId: @learning_goal_ai_evaluation.id}}, user: :student, response: :forbidden | ||
| test_user_gets_response_for :get_by_ai_evaluation_id, params: -> {{learningGoalAiEvaluationId: @learning_goal_ai_evaluation.id}}, user: -> {@teacher}, response: :success | ||
| test_user_gets_response_for :get_by_ai_evaluation_id, params: -> {{learningGoalAiEvaluationId: @learning_goal_ai_evaluation.id}}, user: :teacher, response: :not_found | ||
| end |
| aiFeedbackApproval: aiFeedback, | ||
| falsePositive: aiFalsePos, | ||
| falseNegative: aiFalseNeg, | ||
| Vague: aiVague, |
There was a problem hiding this comment.
Please add a brief comment indicating that the capitalization here is to work around a bug. even if we don't fully understand it, it would be nice to tip ourselves off that lower-casing this key name will cause problems.
cearachew
deleted the
add-controller-for-ai-evaluation-teacher-feedback
branch
This creates a controller for learning_goal_ai_evaluation_feedbacks, and sends data to it when a teacher gives feedback on an AI evaluation via the thumbs up/down buttons and options.
Links
Addresses these two Jira tickets:
https://codedotorg.atlassian.net/browse/AITT-307
https://codedotorg.atlassian.net/browse/AITT-323
Testing story
This includes tests for the backend controller, and updated unit tests for the app
Deployment strategy
Follow-up work
Working on this demonstrated a potential bug/ unexpected behavior with associating JSON key names with the table key names (vague ❌ ; Vague ✅ ). This has a workaround but the original problem is still mysterious.
Privacy
Security
Caching
PR Checklist: