Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update border color of hints and validation feedback in instructions area #54867

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

fisher-alice
Copy link
Contributor

@fisher-alice fisher-alice commented Nov 13, 2023

This PR updates the border (color and dashed -> solid) of hint and validation feedback chat bubbles in the Instructions area. I opted to add the isDashed prop to keep the option of having a dashed border for a ChatBubble since it is a reusable component.

Note that this PR updates hints and feedback in all labs that use the InstructionsCsfMiddleCol component. Slack thread discussion

This PR also makes a small UI update to the ChatBubbleTip now that the border can be solid and not dashed. Before the update, the tip goes beyond the main chat bubble border at the top and bottom of the tip. After the update, the tip goes beyond the main chat bubble border at the top only.

Before update with solid border After update with solid border After update with solid border RTL
Screen Shot 2023-11-14 at 6 39 31 PM Screen Shot 2023-11-14 at 6 19 20 PM Screen Shot 2023-11-14 at 6 42 33 PM

Note that the ChatBubbleTip background covers up the blue border from the main ChatBubble. You can see if the ChatBubbleTip is flush with the ChatBubble (this is what I tried first for the polyline points: '23,23 5,23 23,5'), the border from the ChatBubble can be seen. Thus I updated only the bottom of the ChatBubbleTip.

Screen Shot 2023-11-14 at 6 14 43 PM
Type Before After
Hint dashed, yellow, 1px solid, blue, 2px
Validation Feedback dashed, gray, 1px solid, yellow, 2px

Before update:

(Instructions and Hints)
Screen Shot 2023-11-14 at 3 30 45 PM

(Hints and Feedback)
Screen Shot 2023-11-14 at 3 30 52 PM

After update:

(Instructions and Hints)
Screen Shot 2023-11-14 at 3 27 49 PM

(Hints and Feedback)
Screen Shot 2023-11-14 at 3 28 14 PM

Links

Trello

Testing story

I tested locally in the 2023 HoC progression and also checked in a non-dance 2023 levels (Dance 2019 and Poetry 2023) to make sure hints and feedback look as expected.
Here are a couple screenshots of a poetry 2023 level:

Screen Shot 2023-11-14 at 3 41 56 PM

Screen Shot 2023-11-14 at 3 42 07 PM

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice fisher-alice changed the title Alice/feedback outlines Update hints and validation feedback in instructions area Nov 14, 2023
@fisher-alice fisher-alice changed the title Update hints and validation feedback in instructions area Update border color of hints and validation feedback in instructions area Nov 14, 2023
@fisher-alice fisher-alice marked this pull request as ready for review November 14, 2023 21:47
@fisher-alice fisher-alice requested review from a team and samantha-code November 14, 2023 21:47
@bencodeorg
Copy link
Contributor

To clarify, we're not using a dashed outline anywhere? Seems like a lot of plumbing for something we don't use, do we have some imminent need?

@samantha-code
Copy link

I think if we didn't complete this change this week, the tutorial would still be good to ship so in that sense it is not imminent. We WOULD have to update the videos once this change goes live (which is why we are trying to get it in). Curriculum has been asking for improvements on the visibility of feedback strings for a while and this seemed like a good opportunity to get it prioritized for ALL labs, and we are planning on updating those sprite lab videos as well - not sure if that answered the question.

@fisher-alice
Copy link
Contributor Author

fisher-alice commented Nov 15, 2023

To clarify, we're not using a dashed outline anywhere? Seems like a lot of plumbing for something we don't use, do we have some imminent need?

Good point. Removed the 'plumbing' from the hints and feedback. But left for the ChatBubble since it seems like a reusable component and having the solid/dashed option may be useful.
Update: touched base with Mark and he said that he would prefer having solid/dashed option for ChatBubble.

Copy link
Contributor

@bencodeorg bencodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fisher-alice fisher-alice merged commit 70a646b into staging Nov 15, 2023
2 checks passed
@fisher-alice fisher-alice deleted the alice/feedback-outlines branch November 15, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants