-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update border color of hints and validation feedback in instructions area #54867
Conversation
To clarify, we're not using a dashed outline anywhere? Seems like a lot of plumbing for something we don't use, do we have some imminent need? |
I think if we didn't complete this change this week, the tutorial would still be good to ship so in that sense it is not imminent. We WOULD have to update the videos once this change goes live (which is why we are trying to get it in). Curriculum has been asking for improvements on the visibility of feedback strings for a while and this seemed like a good opportunity to get it prioritized for ALL labs, and we are planning on updating those sprite lab videos as well - not sure if that answered the question. |
Good point. Removed the 'plumbing' from the hints and feedback. But left for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR updates the border (color and dashed -> solid) of hint and validation feedback chat bubbles in the Instructions area. I opted to add the
isDashed
prop to keep the option of having a dashed border for aChatBubble
since it is a reusable component.Note that this PR updates hints and feedback in all labs that use the
InstructionsCsfMiddleCol
component. Slack thread discussionThis PR also makes a small UI update to the
ChatBubbleTip
now that the border can be solid and not dashed. Before the update, the tip goes beyond the main chat bubble border at the top and bottom of the tip. After the update, the tip goes beyond the main chat bubble border at the top only.Note that the
ChatBubbleTip
background covers up the blue border from the mainChatBubble
. You can see if theChatBubbleTip
is flush with theChatBubble
(this is what I tried first for thepolyline
points: '23,23 5,23 23,5'), the border from theChatBubble
can be seen. Thus I updated only the bottom of theChatBubbleTip
.Before update:
(Instructions and Hints)
(Hints and Feedback)
After update:
(Instructions and Hints)
(Hints and Feedback)
Links
Trello
Testing story
I tested locally in the 2023 HoC progression and also checked in a non-dance 2023 levels (Dance 2019 and Poetry 2023) to make sure hints and feedback look as expected.
Here are a couple screenshots of a poetry 2023 level:
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: