Add announcement.json ability for learn page #54935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmanzojr
changed the title
TurnerRiley
approved these changes
Nov 15, 2023
| @@ -34,6 +34,7 @@ def index | |||
| @is_english = request.language == 'en' | |||
| @is_signed_out = current_user.nil? | |||
| @force_race_interstitial = params[:forceRaceInterstitial] | |||
| @courses_announcement = Announcements.get_localized_announcement_for_page("/courses") | |||
There was a problem hiding this comment.
Just for my understanding, where is this specific banner getting assigned to the /courses page so this returns the correct one?
There was a problem hiding this comment.
the get_localized_announcement_for_page method makes use of the announcements.json which is where the correct banner is assigned for /courses page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the banners for the
/coursespage generate fromannouncements.json.Courses.jsxnow makes use of theMarketingAnnouncementBannercomponent in order to use the newspecialAnnouncementprop which represents the banner retrieved fromannouncements.json.Correct Banner is retrieved and
MarketingAnnouncementBannercomponent is being used.Links
Testing story
Local
PR Checklist: