Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds soft-delete to LTI sections. Adding the paranoid behavior messed up some of the cascading deletes, mostly because of the way that we were trying to get deleting a section to delete the LTI section, and vice versa. The only working solution I could find was:
dependent: :destroy
from thehas_many :sections through: :lti_sections
relationship in LTI Courses. Deleting the LTI course will delete the LTI section, which in turn will delete the section, so the additional destroy was redundant.dependent: :destroy
on both sides of the one-to-one relationship between sections and LTI sections. Instead, I added separate methods in each model to delete the corresponding other record. Without doing this, I ended up with endless loops when the two records tried to delete each other.Links
Jira
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: