Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LTI check to teacher_managed_account #54960

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add LTI check to teacher_managed_account #54960

merged 1 commit into from
Nov 15, 2023

Conversation

nicklathe
Copy link
Contributor

@nicklathe nicklathe commented Nov 15, 2023 •
edited

Currently, a student can't delete their account if they have logged in/signed up via an LTI launch. This PR adds a condition to the teacher_managed_account that returns false if the user has an LTI authentication_option.

Links

Jira ticket

Testing story

bundle exec spring testunit ./test/models/user_test.rb

  424/424: [=========================================================================================] 100% Time: 00:00:53, Time: 00:00:53

Finished in 54.47243s
424 tests, 1059 assertions, 0 failures, 0 errors, 0 skips

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@nicklathe
Add LTI check to teacher_managed_account
c203ae1 
  - Add condition that returns false if account is LTI created
  - Add unit test
  - Add LTI Auth Option trait to user factory

Signed-off-by: Nick Lathe <nick.lathe@code.org>
@nicklathe nicklathe requested a review from a team November 15, 2023 19:32
carl-codeorg
carl-codeorg approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@carl-codeorg carl-codeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicklathe nicklathe merged commit 6633d79 into staging Nov 15, 2023
1 of 2 checks passed
@nicklathe nicklathe deleted the P20-582/teacher-managed-fix branch November 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-codeorg carl-codeorg carl-codeorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicklathe @carl-codeorg