[Google Blockly] CT-180: Add single user experiment to persist Google Blockly across levels #55068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeastlake
changed the title
ebeastlake
commented
Nov 20, 2023
| return true if view_options[:blocklyVersion]&.downcase == 'google' | ||
| return false if view_options[:blocklyVersion]&.downcase == 'cdo' | ||
| return false unless @level.uses_google_blockly? | ||
|
|
||
| # Only check DCDO flag if level type uses Google Blockly to avoid performance hit. | ||
| DCDO.get('disable_google_blockly', []).map(&:downcase).exclude?(@level.class.to_s.downcase) |
There was a problem hiding this comment.
Removed because this is no longer needed.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!!
We have entered Pixel Lock for Hour of Code!
Computer Science Education Week will be happening from Dec 4 - Dec 10. Alongside this event, we will
be launching our new Hour of Code activity. Please consider any risk introduced in this PR that
could affect Dance Lab, instructions, saving and logging student progress, caching, or anything
related to the Hour of Code activities, old or new. Even small changes, such as a different button
color, are considered significant during this time. If this change will affect the new Hour of Code
activity in any way, join the morning change review to get your changes approved prior to merging.
Reach out to the Student Labs team for more details!
Typically, we control the Blockly version using a URL param that is not sticky between levels, like
?blocklyVersion=googleor?blocklyVersion=cdo. Before the bug bash for the Sprite Lab migration to mainline Blockly, we want to allow users to enroll in a SingleUser experiment that would persist their choice between levels/labs. This will also make it easier for those of us working on migrating a specific lab to consistently use a given Blockly version without always having to re-add the URL parameter.To enroll:
/experiments/set_single_user_experiment/google_blocklyTo unenroll:
/experiments/disable_single_user_experiment/google_blocklyLinks
Jira ticket: https://codedotorg.atlassian.net/browse/CT-180
Testing story
Tested that enrolling and unenrolling from the experiment works and that the existing URL params also still work as intended.
The video is too big for Github so here's a link: https://drive.google.com/file/d/1jyc-P4wo5-CwbyEZZ8dOQyHBRkawo29d/view?usp=sharing
PR Checklist: