Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create curriculum pathway view #55946

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Conversation

kelbyhawn
Copy link
Contributor

@kelbyhawn kelbyhawn commented Jan 24, 2024

Creates a curriculum_pathway.haml view for use throughout the code.org site.

Jira ticket: ACQ-1405


Desktop

Hovers.mov

Keyboard Nav

Keyboard.mov

Responsive

Screen.Recording.2024-01-25.at.1.00.16.PM.mov

Mobile

Screenshot 2024-01-25 at 12 43 33 PM

@kelbyhawn kelbyhawn requested a review from a team as a code owner January 24, 2024 21:03
@kelbyhawn kelbyhawn requested a review from a team January 25, 2024 21:03
%div

%figure.curriculum-pathway.mobile
.school-wrapper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using helper methods for all of these but kept getting syntax errors — going with the long version in an effort to get this out 🥲

Copy link
Contributor

@TurnerRiley TurnerRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow Kelby this looks amazing !

@kelbyhawn kelbyhawn merged commit 6ba3933 into staging Jan 26, 2024
2 checks passed
@kelbyhawn kelbyhawn deleted the create-curriculum-pathway-view branch January 26, 2024 16:07
@breville
Copy link
Member

Very nice! One suggestion is to render the > transparently when not hovering, so that when hovering, the layout doesn't change.

@kelbyhawn
Copy link
Contributor Author

Very nice! One suggestion is to render the > transparently when not hovering, so that when hovering, the layout doesn't change.

@breville the layout change was in the Figma mock, but I'll ask Moshe if he wants me to change it.

@breville
Copy link
Member

breville commented Jan 30, 2024

Very nice! One suggestion is to render the > transparently when not hovering, so that when hovering, the layout doesn't change.

@breville the layout change was in the Figma mock, but I'll ask Moshe if he wants me to change it.

Fair point. I do thing it's a bit abrupt (text moving just because you hover over it feels less then ideal), and it does lead to some even more abrupt transitions at certain widths, like here:

course-explorer-responsive.mov

@kelbyhawn
Copy link
Contributor Author

Fair point. I do thing it's a bit abrupt (text moving just because you hover over it feels less then ideal), and it does lead to some even more abrupt transitions at certain widths, like here…

I talked to Moshe and we have a solution: Jira ticket!

mikeharv pushed a commit that referenced this pull request Feb 5, 2024
* add --brand_primary_medium css variable

* create curriculum_pathway.haml and curriculum-pathway.scss

* add strings

* refactor and add links to curriculum_pathway.haml

* add background styles

* clean up css

* add mobile version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants