-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create curriculum pathway view #55946
Conversation
%div | ||
|
||
%figure.curriculum-pathway.mobile | ||
.school-wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using helper methods for all of these but kept getting syntax errors — going with the long version in an effort to get this out 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow Kelby this looks amazing !
Very nice! One suggestion is to render the |
@breville the layout change was in the Figma mock, but I'll ask Moshe if he wants me to change it. |
Fair point. I do thing it's a bit abrupt (text moving just because you hover over it feels less then ideal), and it does lead to some even more abrupt transitions at certain widths, like here: course-explorer-responsive.mov |
I talked to Moshe and we have a solution: Jira ticket! |
* add --brand_primary_medium css variable * create curriculum_pathway.haml and curriculum-pathway.scss * add strings * refactor and add links to curriculum_pathway.haml * add background styles * clean up css * add mobile version
Creates a
curriculum_pathway.haml
view for use throughout the code.org site.Jira ticket: ACQ-1405
Desktop
Hovers.mov
Keyboard Nav
Keyboard.mov
Responsive
Screen.Recording.2024-01-25.at.1.00.16.PM.mov
Mobile