Redo: TypeScript build improvements #55981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Jan 26, 2024
|
Side topic: I sooooo wish JSON had included comments, really hobbles it as a configuration format, e.g. |
mikeharv
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Revert "Revert "TypeScript build improvements"" * downgrade typescript * add caret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #55920, without the TypeScript upgrade. Our version of storybook has an issue with TypeScript v5, so I will handle that upgrade separately. The major improvement from the previous version was splitting up the tsconfig, which this contains, along with using incremental mode.
PR Checklist: