Add new self-paced PL certificate image and generation #56291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cates/virtual-pl-certificate
…cates/virtual-pl-certificate
…cates/virtual-pl-certificate
TurnerRiley
approved these changes
Feb 13, 2024
dashboard/lib/certificate_image.rb
Outdated
| end | ||
|
|
||
| def self.prefilled_title_course?(course) | ||
| certificate_template_for(course) != 'blank_certificate.png' | ||
| certificate_template_for(course) != 'blank_certificate.png' && certificate_template_for(course) != 'self_paced_pl_certificate.png' |
There was a problem hiding this comment.
Nit: ['blank_certificate.png', 'self_paced_pl_certificate.png'].include? certificate_template_for(course) (not worth a rebuild though if no other changes)
There was a problem hiding this comment.
I like that! Don't mind a rebuild -- this PR isn't urgent :)
bethanyaconnor
deleted the
bethany/pl-certificates/virtual-pl-certificate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a certificate for self-paced PL! This certificate isn't linked to anywhere yet, but if you happen to know the obfuscated url for the course, this would allow you to generate a PL-specific certificate.
Examples:
Links
product spec: https://docs.google.com/document/d/1Ee02kw_ei2x6wOS06K768dC-kUhGDlydjoE6BZipbPE/edit
Testing story
Some unit testings, but largely manual testing