Fix Violations of and Reenable jsx-a11y/no-noninteractive-tabindex
#56384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, for all but one violation I fixed it by removing the nonfunctional `tabindex` attribute from the non-interactive element. In that last case, the element had a click handler so I added a `role` attribute to make it explicitly interactive.
bencodeorg
approved these changes
Feb 7, 2024
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, for all but one violation I fixed it by removing the nonfunctional
tabindexattribute from the non-interactive element. In that last case, the element had a click handler so I added aroleattribute to make it explicitly interactive.Testing story
I have not manually tested these changes; I checked few of them and confirmed this change is functionally a no-op, but wasn't sure how to find all of them for testing. In particular, the one element for which I added a
rolerather than removing atabindexremains untested.I feel reasonably confident this change is safe despite the lack of testing, but am very open to disagreement. Let me know what you think!
PR Checklist: