[DESIGN2-92] Javalab - revert purple color back to original value #56515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Feb 12, 2024
Comment on lines
+37
to
+38
| // THIS IS AN OLD PURPLE COLOR. DO NOT USE THIS COLOR FOR NEW STYLES. ONLY USE IT FOR JAVALAB HEADER. | ||
| background-color: #7665A0; |
There was a problem hiding this comment.
Worth making a constant (ex. color.$deprecated-purple) to make this extra clear? Not required though, if this is the only usage of it and we want to avoid it being used elsewhere.
There was a problem hiding this comment.
Yeah, that's the only place in the repo we use this deprecated-purple, so I think it's better to leave it as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DESIGN2-92] Javalab - revert purple color back to original value
After #56281 we've found out that for Javalab new purple looks like too much. Decided to revert purple back to original value for Javalab for now. Also there're plans to make a restyle/rebrand of this page in the future.
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: