Curriculum Catalog UI test waits for the home page and jquery to load when creating a new section #56525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Curriculum Catalog UI test to wait for the home page and jquery to load when creating a new section. Before, this test was failing on Firefox seemingly because
jquerywasn't loaded yet. Now, following this slack thread about a similar issue and with waiting for the page to load, the test succeeds.Links
Slack discussion: here
Testing story
First, we made this speculative change on the test server and reran the test (which succeeded). Bethany also locally opened Firefox and created a section through the curriculum catalog successfully.