-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Schools string for top nav #56526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we just need a full sync in/out? Said another way, do we have this string translated somewhere, just maybe not in this file?
The word "schools" is in other strings in this file and other i18n files, but not by itself — does that influence things? |
Yeah -- it means we can't rely on a translation already existing and will have to wait a bit longer to make the change. If it existed by itself, we'd have translations next week. |
Got it, and bummer! |
@kelbyhawn translations are in for 33 languages! |
Woo hoo, thanks @castro-jorge! |
@mgc1194 |
Adds a new string "Schools" for use in the signed out top nav on code.org. Once this string is translated I will replace the Projects link with this Schools link in this PR: #56527
Jira ticket: ACQ-1464