Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schools string for top nav #56526

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Add Schools string for top nav #56526

merged 3 commits into from
Feb 13, 2024

Conversation

kelbyhawn
Copy link
Contributor

@kelbyhawn kelbyhawn commented Feb 12, 2024

Adds a new string "Schools" for use in the signed out top nav on code.org. Once this string is translated I will replace the Projects link with this Schools link in this PR: #56527

Jira ticket: ACQ-1464

@kelbyhawn kelbyhawn requested a review from a team as a code owner February 12, 2024 22:37
@kelbyhawn kelbyhawn requested a review from a team February 12, 2024 22:41
@kelbyhawn kelbyhawn changed the title Add schools string for top nav Add Schools string for top nav Feb 12, 2024
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we just need a full sync in/out? Said another way, do we have this string translated somewhere, just maybe not in this file?

@kelbyhawn
Copy link
Contributor Author

I assume we just need a full sync in/out? Said another way, do we have this string translated somewhere, just maybe not in this file?

The word "schools" is in other strings in this file and other i18n files, but not by itself — does that influence things?

@bethanyaconnor
Copy link
Contributor

Yeah -- it means we can't rely on a translation already existing and will have to wait a bit longer to make the change. If it existed by itself, we'd have translations next week.

@kelbyhawn
Copy link
Contributor Author

Yeah -- it means we can't rely on a translation already existing and will have to wait a bit longer to make the change. If it existed by itself, we'd have translations next week.

Got it, and bummer!

@kelbyhawn kelbyhawn merged commit f2f5dda into staging Feb 13, 2024
2 checks passed
@kelbyhawn kelbyhawn deleted the add-schools-nav-string branch February 13, 2024 20:48
@castro-jorge
Copy link
Contributor

@kelbyhawn translations are in for 33 languages!

@kelbyhawn
Copy link
Contributor Author

@kelbyhawn translations are in for 33 languages!

Woo hoo, thanks @castro-jorge!

@kelbyhawn
Copy link
Contributor Author

kelbyhawn commented Feb 21, 2024

@mgc1194 do you know when should I be able to see this string locally? I'm still seeing the translation missing: en-US.header_schools error. Figured this out! I needed to add the string header_schools to the i18n gsheet 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants