Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amplitude events for update school dialog #56535

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Feb 13, 2024

Adds four amplitude events for the school info update dialog, as spelled out in product spec linked below, plus one added from PR feedback.

I also updated the a11y of this component to make it tab navigable by removing the __useDeprecatedTag. I had to update the styling of the update button: see before and after below.
Shoutout to @wilkie who translated this Storybook last year, which made development here much much faster! So fun to see the fruits of that labor!

To be clear: this is only the first portion of Amplitude work: there is a dialog that follows this if a user presses 'update' that is not yet instrumented.

Screenshot 2024-02-12 at 6 57 03 PM Screenshot 2024-02-12 at 6 57 10 PM Screenshot 2024-02-12 at 6 57 27 PM Screenshot 2024-02-13 at 9 32 39 AM

Before:
Screenshot 2024-02-12 at 6 58 52 PM

After (excuse the active blue outline on the 'x'- this was just me testing out tabnav):
Screenshot 2024-02-12 at 7 03 53 PM

(This is how it looks RTL:)
Screenshot 2024-02-12 at 7 05 50 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested a review from a team February 13, 2024 03:08
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hannahbergam hannahbergam merged commit b88a5c7 into staging Feb 13, 2024
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/school-amplitude branch February 13, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants