Adding amplitude events for update school dialog #56535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds four amplitude events for the school info update dialog, as spelled out in product spec linked below, plus one added from PR feedback.
I also updated the a11y of this component to make it tab navigable by removing the __useDeprecatedTag. I had to update the styling of the update button: see before and after below.
Shoutout to @wilkie who translated this Storybook last year, which made development here much much faster! So fun to see the fruits of that labor!
To be clear: this is only the first portion of Amplitude work: there is a dialog that follows this if a user presses 'update' that is not yet instrumented.
Before:
After (excuse the active blue outline on the 'x'- this was just me testing out tabnav):
(This is how it looks RTL:)
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: