Removing AFE submit page from the flow #56552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelbyhawn
approved these changes
Feb 13, 2024
hannahbergam
commented
Feb 13, 2024
| @@ -5,7 +5,7 @@ import {Button} from 'react-bootstrap'; // eslint-disable-line no-restricted-imp | |||
| import {studio, pegasus} from '@cdo/apps/lib/util/urlHelpers'; | |||
| import color from '@cdo/apps/util/color'; | |||
|
|
|||
| const RETURN_TO = `user_return_to=${pegasus('/afe/submit')}`; | |||
| const RETURN_TO = `user_return_to=${pegasus('/afe')}`; | |||
There was a problem hiding this comment.
@kelbyhawn it actually just works from changing the link here!
TurnerRiley
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing submit page is largely empty, and just hosts the processing for submit after a user is directed to sign in or sign up, completes that action, and the afe submission begins. The page is a landing zone for a user whose info is still being submitted. If the request is successful, the user is redirected to /success.
Now, that work happens on the /afe page itself instead of its own /submit page.
See existing flow in figma here: https://www.figma.com/file/qEFj4WmsjOC5okiMMxLJXq/AFE-Updates-(Dec-2023)?type=design&node-id=1538-384&mode=design&t=W2aVyQ1n5pbKfOve-0
-> The request processes instead in place on the afe page:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: