Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a level-specific prompt field to AI Tutor section of levelbuilder #57051

Merged
merged 19 commits into from Apr 11, 2024

Conversation

kakiha11
Copy link
Contributor

@kakiha11 kakiha11 commented Mar 6, 2024

  • Updated the AI Tutor section of level edit pages to be a React component
  • Added the a section for levelbuilders to add on a level-specific prompt to the system prompt

levelspecific

Added the prompt as a property to levels (see test level below) and added that prompt, when present, to the end of the default system prompt for all three modes of AI Tutor.

Screenshot 2024-03-05 at 8 24 55 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

@kakiha11 kakiha11 requested a review from a team March 6, 2024 04:40
apps/src/aiTutor/types.ts Outdated Show resolved Hide resolved
@Erin007
Copy link
Contributor

Erin007 commented Mar 6, 2024

Looking good! A couple of questions for discussion 👍

@kakiha11 kakiha11 requested a review from ebeastlake April 5, 2024 15:43
@kakiha11 kakiha11 requested review from a team and removed request for ebeastlake April 10, 2024 03:57
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple clean up comments and one question for my understanding

apps/src/aiTutor/levelEditors/AITutorFields.tsx Outdated Show resolved Hide resolved
id="levelPrompt"
value={levelSpecificPrompt || ''}
className={moduleStyles.textarea}
placeholder={`Enter a prompt specific to this level to be added with the default AI Tutor system prompt:\n${generalChatSystemPrompt}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be more helpful to have this information above the input box so users can see the general prompt while they are writing, rather than before they start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@molly-moen What do you think of this?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks good!

Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kakiha11 kakiha11 merged commit c92465d into staging Apr 11, 2024
2 checks passed
@kakiha11 kakiha11 deleted the ct-238/ka-ai-tutor-custom-prompt branch April 11, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants