Teacher dashboard UI tests - part 1 #57269
Conversation
kobryan0619
changed the title
| styles.gridBox, | ||
| styles.gridBoxLevel, | ||
| feedbackStyle, | ||
| 'ui-level-data-cell' |
There was a problem hiding this comment.
Should we add this as id instead of className?
| @@ -60,7 +60,8 @@ export default function LessonProgressColumnHeader({ | |||
| className={classNames( | |||
| styles.gridBox, | |||
| styles.lessonHeaderCell, | |||
| styles.pointerMouse | |||
| styles.pointerMouse, | |||
| 'ui-progress-column' | |||
There was a problem hiding this comment.
Should we add this as id instead of className?
...board/test/ui/features/teacher_tools/teacher_dashboard/teacher_dashboard_progress_v2.feature
Show resolved
Hide resolved
| Then I click selector "a:contains('More Details')" | ||
| And I wait until element "h3:contains(Progress Tracking Icon Key)" is visible | ||
| And I click selector "#ui-close-dialog" | ||
| And element "h3:contains(Progress Tracking Icon Key)" is hidden |
| type="primary" | ||
| size="s" | ||
| onClick={onShowProgressTableV2Change} | ||
| id="ui-test-link-to-new-progress-view" |
There was a problem hiding this comment.
| id="ui-test-link-to-new-progress-view" | |
| id="ui-toggle-progress-views" |
This button will also turn from new to old views.
There was a problem hiding this comment.
Good point - changed!
| @@ -32,6 +33,15 @@ Feature: Using the teacher dashboard | |||
| Then I navigate to teacher dashboard for the section I saved | |||
| And I wait until element "#uitest-course-dropdown" is visible | |||
| And I select the "All the Things! *" option in dropdown "uitest-course-dropdown" | |||
| Then I append "/?enableExperiments=section_progress_v2" to the URL | |||
There was a problem hiding this comment.
What do you think about moving this to line 29 before the v1 progress tab tests to test that it shows up even with the toggle button displayed?
There was a problem hiding this comment.
This was tricky... I could not get the experiment to work unless I added this experiment ON the progress view... I still don't know why that was. For that reason, I added the experiment right before it was needed. BUT I think we could move it to as soon as the test got to the progress page.
| Then I click selector "#ui-test-link-to-new-progress-view" | ||
| And I wait until element "h6:contains(Icon Key)" is visible | ||
| And I wait until element "#ui-test-progress-table-v2" is visible | ||
| And element "#ui-test-progress-table-v2" is visible |
There was a problem hiding this comment.
| And element "#ui-test-progress-table-v2" is visible |
I think this is covered by the line above?
There was a problem hiding this comment.
Correct... chagned!
| @@ -242,4 +252,4 @@ Feature: Using the teacher dashboard | |||
| And I enter the section code into "input.ui-test-join-section" | |||
| And I click selector "button.ui-test-join-section" | |||
| Then I wait until element ".announcement-notification" is visible | |||
| And element ".announcement-notification" contains text matching "You are already an instructor for section" | |||
| And element ".announcement-notification" contains text matching "You are already an instructor for section" | |||
There was a problem hiding this comment.
Do you know what changed here and why? It's probably fine, but just want to check.
There was a problem hiding this comment.
Honestly, I cannot see a difference myself...
This starts to add to UI tests for our teacher_dashboard_V2 work.
teacher_dashboardtestsLinks
Ticket