Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX - Force Reload StatSig Secrets #57478

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Mar 22, 2024

Empty commit to force building new production web application servers as an indirect way to force a restart of pegasus and dashboard services on all production "frontend" servers to ensure new StatSig Secret values are picked up.

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc sureshc marked this pull request as ready for review March 22, 2024 18:35
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou!

@sureshc sureshc merged commit 3932250 into production Mar 22, 2024
@sureshc sureshc deleted the hotfix-force-reload-statsig-secrets branch March 22, 2024 18:35
sureshc added a commit that referenced this pull request Apr 26, 2024
* Update monitor_projects

* HOTFIX - Force Reload StatSig Secrets (#57478)

* Empty commit

* Empty commit to force building new production servers to trigger restart to pick up new StatSig secrets.

* Use Lowercase Value for `ClusterMode` (#58292)

During the DTP which attempted to upsize the Redis cluster we use for
session storage (see
#58262), the
CloudFormation stack update [failed with the error message "Cluster mode
updates are not supported while attempting to update additional
properties"](https://codedotorg.slack.com/archives/C03CK8FGX/p1714167673511629)

According to [this
answer](https://repost.aws/questions/QUj6IF3l-qSsKKkD3yxY_EDw/elasticache-cluster-mode-updates-are-not-supported-while-attempting-to-update-additional-properties#ANrtmd6mpHRYaDBcihifZyhg)
on AWS re:Post, it seems like this is an issue with CFN documentation.
Specifically, the documentation claims that the `ClusterMode` property
should have a value starting with an uppercase letter; either `Enabled`
or `Disabled`, but in reality it expects an entirely lowercase value;
either `enabled` or `disabled`. Because of that discrepancy,
CloudFormation thinks we are attempting to update `ClusterMode` when
we're really just trying to update `CacheNodeType`

To resolve, simply use the expected rather than documented value.

---------

Co-authored-by: Mario Gil Correa <66776217+mgc1194@users.noreply.github.com>
Co-authored-by: wilkie <david.wilkinson@code.org>
Co-authored-by: Nick Lathe <nick.lathe@code.org>
Co-authored-by: Turner Riley <56283563+TurnerRiley@users.noreply.github.com>
Co-authored-by: Kaitie O <kaitie@code.org>
Co-authored-by: Dave Bailey <davidsbailey@users.noreply.github.com>
Co-authored-by: Elijah Hamovitz <elijahhamovitz@gmail.com>
Co-authored-by: Vijaya Manohararaj <124813947+vijayamanohararaj@users.noreply.github.com>
Co-authored-by: Eric Aderhold <eric.aderhold@code.org>
Co-authored-by: Sanchit Malhotra <85528507+sanchitmalhotra126@users.noreply.github.com>
Co-authored-by: carl-codeorg <131809324+carl-codeorg@users.noreply.github.com>
Co-authored-by: Emily Eastlake <emily.eastlake@code.org>
Co-authored-by: bencodeorg <ben@code.org>
Co-authored-by: Hannah Bergam <hannah.bergam@code.org>
Co-authored-by: Jim Thomason <jim@japanesewartuba.com>
Co-authored-by: Dayne <dayne@code.org>
Co-authored-by: D Buchanan <146779710+unlox775-code-dot-org@users.noreply.github.com>
Co-authored-by: Ryan Shipp <1382374+rshipp@users.noreply.github.com>
Co-authored-by: Brendan Reville <breville@users.noreply.github.com>
Co-authored-by: fisher-alice <107423305+fisher-alice@users.noreply.github.com>
Co-authored-by: Bethany Connor <46464143+bethanyaconnor@users.noreply.github.com>
Co-authored-by: Liam Frye-Mason <liam.fryemason@code.org>
Co-authored-by: Pablo M <108825710+pablo-code-org@users.noreply.github.com>
Co-authored-by: Seth Nickell <snickell@gmail.com>
Co-authored-by: Cassi Brenci <cassi.brenci@code.org>
Co-authored-by: cearachew <ceara.chewning@code.org>
Co-authored-by: Darin Webb <darin@code.org>
Co-authored-by: Molly Moen <molly@code.org>
Co-authored-by: Mark Barnes <mark.barnes@code.org>
Co-authored-by: Mike Harvey <43474485+mikeharv@users.noreply.github.com>
Co-authored-by: juanmanzojr <137838584+juanmanzojr@users.noreply.github.com>
Co-authored-by: Jessica Kulwik <jessica@code.org>
Co-authored-by: Code.org Deploy Systems <dev@code.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants