-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX - Force Reload StatSig Secrets #57478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art to pick up new StatSig secrets.
sureshc
requested review from
molly-moen,
hannahbergam,
bethanyaconnor and
a team
March 22, 2024 18:35
molly-moen
approved these changes
Mar 22, 2024
hannahbergam
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou!
8 tasks
sureshc
added a commit
that referenced
this pull request
Apr 26, 2024
* Update monitor_projects * HOTFIX - Force Reload StatSig Secrets (#57478) * Empty commit * Empty commit to force building new production servers to trigger restart to pick up new StatSig secrets. * Use Lowercase Value for `ClusterMode` (#58292) During the DTP which attempted to upsize the Redis cluster we use for session storage (see #58262), the CloudFormation stack update [failed with the error message "Cluster mode updates are not supported while attempting to update additional properties"](https://codedotorg.slack.com/archives/C03CK8FGX/p1714167673511629) According to [this answer](https://repost.aws/questions/QUj6IF3l-qSsKKkD3yxY_EDw/elasticache-cluster-mode-updates-are-not-supported-while-attempting-to-update-additional-properties#ANrtmd6mpHRYaDBcihifZyhg) on AWS re:Post, it seems like this is an issue with CFN documentation. Specifically, the documentation claims that the `ClusterMode` property should have a value starting with an uppercase letter; either `Enabled` or `Disabled`, but in reality it expects an entirely lowercase value; either `enabled` or `disabled`. Because of that discrepancy, CloudFormation thinks we are attempting to update `ClusterMode` when we're really just trying to update `CacheNodeType` To resolve, simply use the expected rather than documented value. --------- Co-authored-by: Mario Gil Correa <66776217+mgc1194@users.noreply.github.com> Co-authored-by: wilkie <david.wilkinson@code.org> Co-authored-by: Nick Lathe <nick.lathe@code.org> Co-authored-by: Turner Riley <56283563+TurnerRiley@users.noreply.github.com> Co-authored-by: Kaitie O <kaitie@code.org> Co-authored-by: Dave Bailey <davidsbailey@users.noreply.github.com> Co-authored-by: Elijah Hamovitz <elijahhamovitz@gmail.com> Co-authored-by: Vijaya Manohararaj <124813947+vijayamanohararaj@users.noreply.github.com> Co-authored-by: Eric Aderhold <eric.aderhold@code.org> Co-authored-by: Sanchit Malhotra <85528507+sanchitmalhotra126@users.noreply.github.com> Co-authored-by: carl-codeorg <131809324+carl-codeorg@users.noreply.github.com> Co-authored-by: Emily Eastlake <emily.eastlake@code.org> Co-authored-by: bencodeorg <ben@code.org> Co-authored-by: Hannah Bergam <hannah.bergam@code.org> Co-authored-by: Jim Thomason <jim@japanesewartuba.com> Co-authored-by: Dayne <dayne@code.org> Co-authored-by: D Buchanan <146779710+unlox775-code-dot-org@users.noreply.github.com> Co-authored-by: Ryan Shipp <1382374+rshipp@users.noreply.github.com> Co-authored-by: Brendan Reville <breville@users.noreply.github.com> Co-authored-by: fisher-alice <107423305+fisher-alice@users.noreply.github.com> Co-authored-by: Bethany Connor <46464143+bethanyaconnor@users.noreply.github.com> Co-authored-by: Liam Frye-Mason <liam.fryemason@code.org> Co-authored-by: Pablo M <108825710+pablo-code-org@users.noreply.github.com> Co-authored-by: Seth Nickell <snickell@gmail.com> Co-authored-by: Cassi Brenci <cassi.brenci@code.org> Co-authored-by: cearachew <ceara.chewning@code.org> Co-authored-by: Darin Webb <darin@code.org> Co-authored-by: Molly Moen <molly@code.org> Co-authored-by: Mark Barnes <mark.barnes@code.org> Co-authored-by: Mike Harvey <43474485+mikeharv@users.noreply.github.com> Co-authored-by: juanmanzojr <137838584+juanmanzojr@users.noreply.github.com> Co-authored-by: Jessica Kulwik <jessica@code.org> Co-authored-by: Code.org Deploy Systems <dev@code.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty commit to force building new production web application servers as an indirect way to force a restart of pegasus and dashboard services on all production "frontend" servers to ensure new StatSig Secret values are picked up.
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: