on the test server, write ruby errors to cloudwatch and honeybadger #57662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
changed the title
davidsbailey
commented
Mar 29, 2024
Comment on lines
+14
to
+15
| test: | ||
| report_data: true |
There was a problem hiding this comment.
syntax derived from these sources:
davidsbailey
commented
Apr 1, 2024
Comment on lines
+78
to
+87
| if CDO.running_web_application? | ||
| # Use default logging formatter so that PID and timestamp are not suppressed. | ||
| config.log_formatter = Logger::Formatter.new | ||
|
|
||
| # Log condensed lines to syslog for centralized logging. | ||
| config.lograge.enabled = true | ||
| config.lograge.formatter = Lograge::Formatters::Cee.new | ||
| require 'syslog/logger' | ||
| config.logger = Syslog::Logger.new 'dashboard', Syslog::LOG_LOCAL0 | ||
| end |
There was a problem hiding this comment.
similar logging config to other environments, but limited to running web app to make sure it does not get set in unit tests.
There was a problem hiding this comment.
👍 in particular, very similar to the config for production.rb
cat5inthecradle
approved these changes
Apr 3, 2024
snickell
approved these changes
Apr 4, 2024
Comment on lines
+78
to
+87
| if CDO.running_web_application? | ||
| # Use default logging formatter so that PID and timestamp are not suppressed. | ||
| config.log_formatter = Logger::Formatter.new | ||
|
|
||
| # Log condensed lines to syslog for centralized logging. | ||
| config.lograge.enabled = true | ||
| config.lograge.formatter = Lograge::Formatters::Cee.new | ||
| require 'syslog/logger' | ||
| config.logger = Syslog::Logger.new 'dashboard', Syslog::LOG_LOCAL0 | ||
| end |
There was a problem hiding this comment.
👍 in particular, very similar to the config for production.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today it is difficult to debug server errors on the test machine. this is especially bad when working with Active Job, because there is no easy way to surface these errors in the UI. Logs are currently written to dashboard/log/test.log, in rails format, which does not include a timestamp:
This config change makes the logs show up in cloudwatch and also includes a timestamp in /var/log/syslog:
f5c0597 also makes the error details show up in honey badger.
Testing story
patched onto the test machine, and verified that new ruby errors appear in:
test-sysloggroup in cloudwatch