[ProgressV2] Make lesson headers tab navigable #57740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobryan0619
reviewed
Apr 4, 2024
| @@ -5,6 +5,21 @@ | |||
| background-color: white; | |||
| } | |||
|
|
|||
| @mixin remove-default-button-styles { | |||
There was a problem hiding this comment.
Ahhh... this is the stuff I have NOT seen in our codebase much. I would love to have some more conversations around standardizing use of it - perhaps accessibility is a great place to start??? It seems like an obvious use for @Mixins :)
kobryan0619
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns both expanded and unexpanded lesson headers into buttons. This is to allow for better tab navigation and screen reader accessibility.
Links
TEACH-882
Testing story
Manual testing that no UI changes have been made and that lesson headers are now tab navigable
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: