Adds Experiment flag to School Association, UI tests #57873

hannahbergam · 2024-04-08T20:03:17Z

This PR adds an experiment flag school_association_v2 to be used to test the new school association flow. It also utilizes that flag to write a feature file (including an eyes test) for the sign up flow. I was able to watch it work/troubleshoot via a Saucelabs tunnel (and commenting out the eyes lines) - See the saucelabs run below.

As a bonus, we didn't have any ui/eyes test coverage of this sign up flow before, so yay! 🎉

trimmed.mp4

This required adding some ids to existing buttons/inputs/dropdowns.

Additionally, this will technically make the new school association public for folks to experience on production with the experiment flag ?enableExperiments=school_association_v2

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Links

spec:
jira ticket: https://codedotorg.atlassian.net/browse/ACQ-1610

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked

hannahbergam · 2024-04-09T00:03:43Z

apps/src/lib/util/AnalyticsConstants.js

@@ -36,7 +36,6 @@ const EVENTS = {
  COUNTRY_SELECTED: 'User Selects Country',
  ZIP_CODE_ENTERED: 'Valid Zip Code Entered',
  SCHOOL_SEARCH_INPUT_ENTERED: 'School Search Input Entered',
-  SCHOOL_LIST_OPENED: 'School List Opened',


This is a followup from a conversation here: https://docs.google.com/document/d/1Ulaxj3K6AMNOOjw_244LNOV5ypuHJMjGpUItXpZuC4I/edit?disco=AAABJx8KQyg

hannahbergam · 2024-04-09T00:04:12Z

apps/src/sites/studio/pages/devise/registrations/_finish_sign_up.js

@@ -236,28 +237,37 @@ $(document).ready(() => {

  function renderSchoolInfo() {
    if (schoolInfoMountPoint) {
-      ReactDOM.render(


This is not edited: just moved

hannahbergam · 2024-04-09T00:04:34Z

apps/src/templates/SchoolZipSearch.jsx

@@ -51,7 +51,6 @@ export default function SchoolZipSearch({fieldNames, zip}) {
      sendAnalyticsEvent(EVENTS.DO_NOT_TEACH_AT_SCHOOL_CLICKED, {});
    } else if (schoolId === SELECT_A_SCHOOL) {
      ncesId = '';
-      // sendAnalyticsEvent(EVENTS.SCHOOL_LIST_OPENED, {});


See comment above: we decided to move forward without this event

dmcavoy · 2024-04-09T00:12:26Z

So exciting to see this! @hannahbergam one wonder. Can we make the box for school association as big as it will need to be for all the inputs? I feel like that will cut down on the "surprise" feeling.

hannahbergam · 2024-04-09T00:17:28Z

So exciting to see this! @hannahbergam one wonder. Can we make the box for school association as big as it will need to be for all the inputs? I feel like that will cut down on the "surprise" feeling.

I could understand that. I think it might look a little funky as we only need two fields for non-us (and I imagine I'd be setting a fixed height large enough for the max fields), but maybe that's all in my head. Do you want just empty grey space?

dmcavoy · 2024-04-09T00:29:48Z

So exciting to see this! @hannahbergam one wonder. Can we make the box for school association as big as it will need to be for all the inputs? I feel like that will cut down on the "surprise" feeling.

I could understand that. I think it might look a little funky as we only need two fields for non-us (and I imagine I'd be setting a fixed height large enough for the max fields), but maybe that's all in my head. Do you want just empty grey space?

Ya I wondered about this too. I wonder what Moshe thinks. Maybe we ask him tomorrow?

hannahbergam · 2024-04-09T01:07:19Z

So exciting to see this! @hannahbergam one wonder. Can we make the box for school association as big as it will need to be for all the inputs? I feel like that will cut down on the "surprise" feeling.

I could understand that. I think it might look a little funky as we only need two fields for non-us (and I imagine I'd be setting a fixed height large enough for the max fields), but maybe that's all in my head. Do you want just empty grey space?

Ya I wondered about this too. I wonder what Moshe thinks. Maybe we ask him tomorrow?

🙌🏼

dashboard/test/ui/features/acquisition_products/sign_up.feature

apps/src/sites/studio/pages/devise/registrations/_finish_sign_up.js

bethanyaconnor

🎉

…oc-experiment-flag

This reverts commit 8f9122f.

#57978) This reverts commit 8f9122f.

…57873)…" This reverts commit bda7d08.

#57980) * Revert "Revert "Adds Experiment flag to School Association, UI tests (#57873)…" This reverts commit bda7d08. * writing new step for random email

added experiment flag, started feature file

9c57a37

hannahbergam changed the title ~~added experiment flag, started feature file~~ Adds Experiment flag to School Association, UI tests Apr 8, 2024

hannahbergam added 2 commits April 8, 2024 16:55

yayyyyy the test works

1de3ce3

removing comment

42d12b6

hannahbergam commented Apr 9, 2024

View reviewed changes

hannahbergam marked this pull request as ready for review April 9, 2024 00:05

hannahbergam requested a review from a team April 9, 2024 00:05

bethanyaconnor reviewed Apr 9, 2024

View reviewed changes

dashboard/test/ui/features/acquisition_products/sign_up.feature Show resolved Hide resolved

bethanyaconnor reviewed Apr 9, 2024

View reviewed changes

dashboard/test/ui/features/acquisition_products/sign_up.feature Outdated Show resolved Hide resolved

hannahbergam added 2 commits April 9, 2024 10:52

updating school selection

6b01f3d

pr feedback

60fcaa3

bethanyaconnor reviewed Apr 9, 2024

View reviewed changes

apps/src/sites/studio/pages/devise/registrations/_finish_sign_up.js Show resolved Hide resolved

bethanyaconnor approved these changes Apr 9, 2024

View reviewed changes

hannahbergam added 2 commits April 10, 2024 13:09

Merge remote-tracking branch 'origin/staging' into hbergam/school-ass…

6fc45d5

…oc-experiment-flag

updating feature file to fix saucelabs failure

e522598

hannahbergam merged commit 8f9122f into staging Apr 11, 2024
2 checks passed

hannahbergam deleted the hbergam/school-assoc-experiment-flag branch April 11, 2024 18:30

hannahbergam added a commit that referenced this pull request Apr 12, 2024

Revert "Adds Experiment flag to School Association, UI tests (#57873)"

2b61fbf

This reverts commit 8f9122f.

hannahbergam mentioned this pull request Apr 12, 2024

Revert "Adds Experiment flag to School Association, UI tests" #57978

Merged

hannahbergam added a commit that referenced this pull request Apr 12, 2024

Revert "Adds Experiment flag to School Association, UI tests (#57873)" (

bda7d08

#57978) This reverts commit 8f9122f.

hannahbergam added a commit that referenced this pull request Apr 12, 2024

Revert "Revert "Adds Experiment flag to School Association, UI tests (#…

c2e86f6

…57873)…" This reverts commit bda7d08.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Experiment flag to School Association, UI tests #57873

Adds Experiment flag to School Association, UI tests #57873

hannahbergam commented Apr 8, 2024 •

edited

hannahbergam Apr 9, 2024

hannahbergam Apr 9, 2024

hannahbergam Apr 9, 2024

dmcavoy commented Apr 9, 2024

hannahbergam commented Apr 9, 2024

dmcavoy commented Apr 9, 2024

hannahbergam commented Apr 9, 2024

bethanyaconnor left a comment

Adds Experiment flag to School Association, UI tests #57873

Adds Experiment flag to School Association, UI tests #57873

Conversation

hannahbergam commented Apr 8, 2024 • edited

Warning!!

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

hannahbergam Apr 9, 2024

Choose a reason for hiding this comment

hannahbergam Apr 9, 2024

Choose a reason for hiding this comment

hannahbergam Apr 9, 2024

Choose a reason for hiding this comment

dmcavoy commented Apr 9, 2024

hannahbergam commented Apr 9, 2024

dmcavoy commented Apr 9, 2024

hannahbergam commented Apr 9, 2024

bethanyaconnor left a comment

Choose a reason for hiding this comment

hannahbergam commented Apr 8, 2024 •

edited