Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Project string #57878

Merged
merged 3 commits into from Apr 9, 2024
Merged

Add New Project string #57878

merged 3 commits into from Apr 9, 2024

Conversation

kelbyhawn
Copy link
Contributor

@kelbyhawn kelbyhawn commented Apr 8, 2024

Adds a New Project string ahead of the Create Account Button A/B test. Also added to the i18n gsheet.

The related Create Account string already exists on both the en.yml file and the i18n gsheet, but these don't appear to have been translated yet.

Jira ticket: ACQ-1722

@kelbyhawn kelbyhawn requested a review from a team as a code owner April 8, 2024 22:06
@kelbyhawn kelbyhawn requested a review from a team April 8, 2024 22:42
Copy link
Contributor

@hannahbergam hannahbergam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏼 Yay! Can you call out the Create Account string too when you let the i18n team know about this one?

@kelbyhawn
Copy link
Contributor Author

🙌🏼 Yay! Can you call out the Create Account string too when you let the i18n team know about this one?

Yes definitely, I had already planned to! 😄

@kelbyhawn kelbyhawn merged commit c19d1b0 into staging Apr 9, 2024
2 checks passed
@kelbyhawn kelbyhawn deleted the create-account-add-strings branch April 9, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants