Update AichatView styling including scrolling #57894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher-alice
commented
Apr 9, 2024
| @@ -78,52 +78,50 @@ const AichatView: React.FunctionComponent = () => { | |||
|
|
|||
| return ( | |||
| <div id="aichat-lab" className={moduleStyles.aichatLab}> | |||
| <div className={moduleStyles.columnFlexContainer}> | |||
There was a problem hiding this comment.
Removed this <div> and added column flex to aichatLab.
This reverts commit 62c6154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the styling of
AichatViewand includes:AichatViewbefore update:AichatViewafter update (resizing of columns):Screencast video after updates:
scroll.mp4
Links
jira
Testing story
I tested locally on different screen sizes and at full-screen.
Deployment strategy
Follow-up work
In the Retrieval customization panel, I wonder if users may click on 'Add' , but then forget to click on 'Update' to save the retrieval contexts. Perhaps we disable 'Publish' until 'Add' is clicked?
Posted concern in Slack thread.
Privacy
Security
Caching
PR Checklist: