Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Blockly] add field colour plugin #57895

Merged
merged 1 commit into from Apr 9, 2024
Merged

Conversation

mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Apr 9, 2024

When Blockly v11 is release, several field types are being deleted from core and will only be available via plugins: https://github.com/google/blockly/releases/tag/blockly-v11.0.0-beta.4

The one that needs to be addressed is FieldColour which we use for several built-in and custom blocks. This branch adds the plugin and install its built-in blocks, effectively replacing those provided with (v10) core. When we are ready to upgrade this should make things more seamless.

I confirmed that several blocks with color fields are still working as expected and further confirmed that the field methods being used are coming from the plugin source rather than core.

image

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Links

Jira - https://codedotorg.atlassian.net/browse/CT-490

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv requested a review from a team April 9, 2024 15:25
@mikeharv mikeharv merged commit c3daafd into staging Apr 9, 2024
2 checks passed
@mikeharv mikeharv deleted the mike/fieldColour-plugin branch April 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants