Update Curriculum Recommender fake curricula time stamps #57902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, there were flaky Curriculum Recommender unit tests. Nearly all the values are hard-coded to test the recommenders so my guess is that the flakiness came from setting the published dates and comparing them. If a curriculum was published within 1 or 2 years ago, it gains a certain number of points when being scored. Since the test curricula had hard-coded published dates that were right on the cusps (e.g. Today minus one year exactly), I think sometimes the test would run and a given curriculum would have been considered published within one year ago, and sometimes not (thus, why the failing test showed the curricula scores in the wrong order).
This PR increases each published date by one month so that there are no dates right on the cusp of scoring points or not.
Links
Slack discussion: here
Testing story
Tested locally and it's still passing.