Fix Facebook icon not loading in Eyes tests - V2 #57909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanyaconnor
approved these changes
Apr 9, 2024
|
Interestingly, this icon appears to load slowly because we are waiting for the reachability test for Facebook to complete, here. If we are happy for the Eyes test to test our UI, and not the reachability of Facebook, we could add support for an optional, internal URL parameter so that Eyes tests always show the icon, which will then render immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #56321 to try and fix a flaky eyes test on the certificates page Facebook icon. Increases the wait time from 2 seconds to 5 seconds.
馃挰 Slack convo