Add amplitude event for moving rubric window #57931
Conversation
| EVENTS.TA_RUBRIC_WINDOW_MOVE_END, | ||
| {window_x_end: 0, window_y_end: 0} |
There was a problem hiding this comment.
this is confusing... shouldn't these be 100/100? are you able to validate that the right values come through in manual testing?
There was a problem hiding this comment.
Yes, it works locally. This is something I read about with the way that react testing library renders components. I had a similar issue when writing the unit test for moving the window (i.e., it didn't return the correct values, but it did register that the values had changed). I'll see if I can find a link to what I read before.
There was a problem hiding this comment.
Sorry, meant to say that I've tested manually and gotten the correct results:
There was a problem hiding this comment.
that would be great. I'm not sure how common this will be, but until it becomes common knowledge I would suggest including a short explanation with a link to the issue as a code comment
There was a problem hiding this comment.
Here's the explanation that I pieced together: React Testing Library uses JSDom as the basis for its render function. JSDom doesn't actually render elements, so everything will show up with a position of (0, 0). For the draggable unit test, I was able to get around this because the draggable component applies a transformation to the component, so if you look at the translation, you'll see the change, but the raw x and y position values will always show as (0, 0). It's possible you can get more accurate position readings by using RTL with Jest, but I haven't confirmed that.
jsdom/jsdom#1590
Added Amplitude analytics event for reporting when the rubric window is moved. Reports movement start and end positions in two separate events.
Jira Ticket: AITT-554