Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress] Split LTI feedback banner into generic reusable component #57933

Merged
merged 4 commits into from Apr 11, 2024

Conversation

lfryemason
Copy link
Contributor

@lfryemason lfryemason commented Apr 10, 2024

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

No UI changes should be made. This PR just splits the rendering and the LTI specific logic into two separate files.

This is so that in a future PR, I can reuse the FeedbackBanner component for a Progress V2 feedback banner.

Screen.Recording.2024-04-10.at.1.18.45.PM.mov

Links

TEACH-1012

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@lfryemason lfryemason marked this pull request as ready for review April 10, 2024 20:23
Copy link
Contributor

@kobryan0619 kobryan0619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Love getting more reusable components in here!

Copy link
Contributor

@artem-vavilov artem-vavilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🙌🏻

@lfryemason lfryemason merged commit b91cde1 into staging Apr 11, 2024
2 checks passed
@lfryemason lfryemason deleted the lfm/p-banner branch April 11, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants