Move Instructed PL Sections to My PL page #57947

TurnerRiley · 2024-04-10T23:33:53Z

Moves the Professional Learning sections the user is teaching from studio.code.org/home to studio.code.org/my-professional-learning.

Following the spec, this PR should:

Show the table of the PL sections the user is teaching
- Show it only for facilitators (under the "My Facilitator Center" tab), universal instructors (under the "Instructors" tab), and peer reviewers (under the "Instructors" tab)
- Show the "Create Section" component
Show the co-teacher invites banners for professional learning sections that were on the Teacher Dashboard
Remove the PL sections table from the Teacher Dashboard and replace with a short message with a redirect to the My PL page

Note about recreating the Owned Sections Table

Unfortunately, there are a lot of different table setups used across the Teacher Dashboard and the My PL page so it was not as simple as moving the OwnedSectionsTable component over because the styling was pretty off as the My PL page's styles, the imported styles from tableConstants.js, and the in-file styles within a styles object were all blending together. I figured taking the time to refactor OwnedSectionsTable to maintain its current styles on the Teacher Dashboard but have different functionality and styling on the My PL page would be scope creep. So, my solution was to make a similar OwnedPlSectionsTable that is the same content copied over but with anything unnecessary removed. I also consolidated the style updates for this in the tableConstants.js file so that it wasn't as confusing to track. If this seems like a concern I'm open to pushback and/or can make a ticket for building out this table following the way Kelby did with the SelfPacedProgressTable so that the styles can be better reused.

Demos

View of page by permission

Facilitator:
(note: this Facilitator also has a non-PL section to demonstrate that this table only shows PL sections (both active and archived))

Universal instructor:

Peer reviewer:

Teacher (should not be able to see it):

Co-teacher invite

Teacher Dashboard message where table used to be

Links

Jira ticket: here
Spec: here
Figma: here

Testing story

Local testing and adding a Storybook for OwnedPlSectionsTable.

…her-homepage

dmcavoy · 2024-04-16T00:37:02Z

I'm so excited to see this coming too life! Yay!!

Nit: Can we update the tab names to what is on this page in figma: https://www.figma.com/file/sZ6d1uhJWFksJ6j3Fnmbnc/PL-Flow-Improvements?type=design&node-id=1958-8045&mode=design&t=x4CDcEPgC2GtTFe6-0

Professional Learning
Facilitator Center
Regional Partner Center
Workshop Organizer Center
Instructor Center

TurnerRiley · 2024-04-16T16:38:29Z

I'm so excited to see this coming too life! Yay!!

Nit: Can we update the tab names to what is on this page in figma: https://www.figma.com/file/sZ6d1uhJWFksJ6j3Fnmbnc/PL-Flow-Improvements?type=design&node-id=1958-8045&mode=design&t=x4CDcEPgC2GtTFe6-0

Professional Learning Facilitator Center Regional Partner Center Workshop Organizer Center Instructor Center

Oh gotcha I was going off the spec tab names, I'll update these! Do we still want to do "Instructors" instead of "Instructor Center" like we discussed offline?

bethanyaconnor · 2024-04-16T18:47:23Z

apps/src/code-studio/pd/professional_learning_landing/LandingPage.jsx

+  //   value: 'myWorkshopOrganizerCenter',
+  //   text: i18n.plLandingTabWorkshopOrganizerCenter(),
+  // },
+  // {


nit: should this one still be commented out?

I think since we haven't set up any content yet for those tabs I've been leaving them commented out until they are useful. Otherwise Regional Partners and Workshop Organizers will have empty tabs

bethanyaconnor · 2024-04-16T18:49:26Z

apps/src/code-studio/pd/professional_learning_landing/LandingPage.jsx

        )}
-        {deeperLearningCourseData?.length >= 1 && (
+        {['myFacilitatorCenter', 'instructors'].includes(currentTab) && (


The facilitator tab should have more components at some point. While adding those components is outside the scope of this PR, it might be worth separating out this logic

Yes for sure, my plan once we started implementing more components was to simplify the logic to a series of {shouldRenderXComponent && (<XComponent/>)} where shouldRenderXComponent would contain the logic of checking if the user has the right permissions and any other qualifications

bethanyaconnor · 2024-04-16T18:51:19Z

apps/src/templates/teacherDashboard/OwnedSections.jsx

+
+    return isPlSections ? (
+      <OwnedPlSectionsTable
+        isPlSections={true}


is isPlSections needed?

No not anymore, I guess I just wasn't sure how much I should change in the scope of this PR for updating OwnedSections and OwnedSectionsTable. Since this change would remove the need for isPlSections in several files would it be okay if I did a followup cleanup task for it?

Cleanup work set up in this PR: #58075

But it's not a prop on OwnedPlSectionsTable is it?

Maybe to clarify, totally fine with cleaning it up on OwnedSectionsTable as a follow-up but I'd prefer it be removed here in this PR.

Oh gotcha! Yes you're super right, just committed a fix!

… there

bethanyaconnor · 2024-04-17T19:59:49Z

apps/test/unit/code-studio/pd/professional_learning_landing/landingPageTest.js

Thank you for adding all of these tests!!

bethanyaconnor · 2024-04-17T20:01:04Z

dashboard/test/ui/features/teacher_tools/pl_sections.feature

@@ -1,45 +1,16 @@
 @no_mobile
 Feature: Professional learning Sections

-  Scenario: Create new professional learning section as levelbuilder


Just so I'm clear, it looks like the test for "as a levelbuilder" was removed but creating PL sections is still covered by other tests in this file?

Yep! I removed it because this section was moved to the My PL page and levelbuilders won't have their own view to see this section there

bethanyaconnor

🎉

TurnerRiley added 2 commits April 10, 2024 15:03

set up framework

4d89283

attempt to pull in section data

d0a2172

TurnerRiley requested a review from a team as a code owner April 10, 2024 23:33

kelbyhawn and others added 11 commits April 11, 2024 09:21

add skip link to self-paced section on LandingPage.jsx

233e5cb

add updated PL section to TeacherHomepage.jsx

4139dfc

update comment

e9b1319

update icon

c51e2a6

add unit test to TeacherHomepageTest.js

f7265a8

Merge branch 'staging' into remove-recent-courses-component-from-teac…

e34e4f7

…her-homepage

replace div tag with section tag to fix spacing on online pl courses

e2370c0

fix redux to get sections

b018d2f

update strings to reflect kelbys skip link style on my pl page

fe40bf5

Merge branch 'staging' into remove-recent-courses-component-from-teac…

f1ea23e

…her-homepage

merge in kelbys strings

3218519

TurnerRiley changed the base branch from staging to remove-recent-courses-component-from-teacher-homepage April 12, 2024 17:03

TurnerRiley added 5 commits April 12, 2024 10:05

remove unnecessary changes

7b5f8c5

setup strings on teacher dashboard

1ba0841

increase permission access

e65709f

redux get coteacherInvite

4b53719

add Create Section component

aa48e09

Base automatically changed from remove-recent-courses-component-from-teacher-homepage to staging April 15, 2024 15:41

TurnerRiley added 7 commits April 15, 2024 09:55

merge in staging

c77c227

set up new component and fix styles for pl sections table

d8d8ef0

add instructors tab

4a67a02

update storybook and participant type column formatter

44f58ff

fix weird spacing for sections

e64f892

remove blank lines

284048d

remove banner margin bottom inline style

dbb985e

TurnerRiley requested a review from a team April 16, 2024 00:13

dmcavoy requested review from a team and lfryemason and removed request for a team April 16, 2024 00:38

update strings to match Figma

4c90cc0

TurnerRiley removed the request for review from a team April 16, 2024 17:27

bethanyaconnor reviewed Apr 16, 2024

View reviewed changes

add unit tests for showing right tabs

dd279b0

TurnerRiley requested a review from bethanyaconnor April 16, 2024 19:40

TurnerRiley added 3 commits April 16, 2024 13:22

remove pl specific tests on TeacherSections since we no longer render…

eeb0ad8

… there

Merge branch 'staging' into setup-pl-sections-on-my-pl

2ef1f39

update ui test behaviors

fc02ae4

TurnerRiley mentioned this pull request Apr 17, 2024

Cleanup OwnedSections component #58075

Merged

bethanyaconnor reviewed Apr 17, 2024

View reviewed changes

TurnerRiley added 2 commits April 17, 2024 13:04

remove unused parameter

e24fcb1

merge in staging

1ee8e3b

bethanyaconnor approved these changes Apr 17, 2024

View reviewed changes

TurnerRiley merged commit 771e1ea into staging Apr 17, 2024
2 checks passed

TurnerRiley deleted the setup-pl-sections-on-my-pl branch April 17, 2024 21:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Instructed PL Sections to My PL page #57947

Move Instructed PL Sections to My PL page #57947

TurnerRiley commented Apr 10, 2024 •

edited

dmcavoy commented Apr 16, 2024 •

edited

TurnerRiley commented Apr 16, 2024

bethanyaconnor Apr 16, 2024

TurnerRiley Apr 16, 2024

bethanyaconnor Apr 16, 2024

TurnerRiley Apr 16, 2024

bethanyaconnor Apr 16, 2024

TurnerRiley Apr 16, 2024 •

edited

TurnerRiley Apr 17, 2024

bethanyaconnor Apr 17, 2024

bethanyaconnor Apr 17, 2024

TurnerRiley Apr 17, 2024

bethanyaconnor Apr 17, 2024

bethanyaconnor Apr 17, 2024

TurnerRiley Apr 17, 2024

bethanyaconnor left a comment

Move Instructed PL Sections to My PL page #57947

Move Instructed PL Sections to My PL page #57947

Conversation

TurnerRiley commented Apr 10, 2024 • edited

Note about recreating the Owned Sections Table

Demos

View of page by permission

Co-teacher invite

Teacher Dashboard message where table used to be

Links

Testing story

dmcavoy commented Apr 16, 2024 • edited

TurnerRiley commented Apr 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TurnerRiley Apr 16, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bethanyaconnor left a comment

Choose a reason for hiding this comment

TurnerRiley commented Apr 10, 2024 •

edited

dmcavoy commented Apr 16, 2024 •

edited

TurnerRiley Apr 16, 2024 •

edited