Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

School Association UI Tweaks #57966

Merged
merged 9 commits into from Apr 16, 2024
Merged

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Apr 11, 2024

This PR handles several UI updates as detailed below. I did switch back to the form saving the raw ncesId (which might be something like 'clickToAdd') so I added those strings to the cleanup work (thus assigning an empty ncesId) in the finish_sign_up.js file.

  • Divider line in dropdown (opt groups)
  • US at the top
  • Dropdown appears at same time as zip but is disabled
    • In addition, creates disabled states for label and button below
  • Fixed width styling on input box (followup: Ben is working on fixing the width to the dropdowns)
  • Update the string for add school
  • Adds a new button ‘I don’t teach in a school setting' to below the dropdown
  • Moves the static options to the bottom of the schools list
  • Moves ‘select a school’ option to top of schools list
Screen.Recording.2024-04-12.at.1.52.34.PM.mov
Screenshot 2024-04-11 at 12 28 51 PM Screenshot 2024-04-11 at 4 49 16 PM

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam marked this pull request as ready for review April 12, 2024 21:08
@hannahbergam hannahbergam requested a review from a team as a code owner April 12, 2024 21:08
@hannahbergam hannahbergam requested a review from a team April 12, 2024 21:09
Copy link
Contributor

@TurnerRiley TurnerRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super stoked about how all this looks! Just had a couple tiny nits/questions

apps/src/templates/SchoolDataInputs.jsx Outdated Show resolved Hide resolved
apps/src/templates/SchoolDataInputs.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after addressing Turner's comments!

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hannahbergam hannahbergam merged commit cc0f1d9 into staging Apr 16, 2024
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/school-assoc-ui-tweaks branch April 16, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants