Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated product tour UI test #57973

Merged
merged 7 commits into from Apr 15, 2024
Merged

Updated product tour UI test #57973

merged 7 commits into from Apr 15, 2024

Conversation

Nokondi
Copy link
Contributor

@Nokondi Nokondi commented Apr 11, 2024 •
edited

Updated UI and unit tests for the AI rubric product tour. Update includes the following:

  • UI test checks for correct data displayed in the rubric during the tour and after the tour ends
  • UI test restarts tour using button in rubric header
  • UI test backtracks through tour using Back button
  • UI test checks that tour does not automatically load after teacher completes it and reloads the page
  • Eyes test for the complete tour
  • Unit tests to confirm that tour does not run on non-assessment levels

@davidsbailey
Copy link
Member

what do you think about covering this item from the jira ticket:

  • no product tour on non-eval levels

you could append it to the current product tour scenario, just navigate and then confirm that the product tour is not enabled?

@Nokondi Nokondi requested a review from a team as a code owner April 12, 2024 19:01
davidsbailey
davidsbailey reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-request review when you are ready for another look. thanks!

davidsbailey
davidsbailey approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates!

@Nokondi Nokondi merged commit d27cc42 into staging Apr 15, 2024
2 checks passed
@Nokondi Nokondi deleted the update-product-tour-ui-test branch April 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nokondi @davidsbailey