[ProgressV2] Create a new feature feedback endpoint for progress feedback #57990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etaderhold
reviewed
Apr 12, 2024
etaderhold
reviewed
Apr 12, 2024
| test 'show - returns nothing when no Feedback exists for the current user' do | ||
| get :show, params: {form_key: 'progress_v2'}, format: :json | ||
|
|
||
| assert_response :ok |
There was a problem hiding this comment.
Could you check for an empty response body here?
|
|
||
| t.index [:user_id, :form_key], unique: true | ||
|
|
||
| t.datetime :created_at, null: false |
There was a problem hiding this comment.
This is a more standard way of creating created_at and updated_at columns.
Suggested change
| t.datetime :created_at, null: false | |
| t.timestamps |
| assert_response :unprocessable_entity | ||
| assert_equal '["Satisfied is not included in the list"]', response.body | ||
| end | ||
|
|
There was a problem hiding this comment.
A test to ensure users can't leave feedback on the same thing twice would be nice.
etaderhold
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Based on this PR to add LTI feedback: https://github.com/code-dot-org/code-dot-org/pull/57517/files
This adds a simple create and show feedback endpoint for a thumbs up or thumbs down feedback form. This feedback is specifically intended for new features and will be used for the new progress view feedback form.
This feedback is reusable because it uses a
form_keyidentifier to determine which feedback form the user has answered. For the progress implementation, this will beprogress_v2which is currently the only allowed value.Adds a migration to create the table and API endpoints. These endpoints will be called in a future PR.
Links
TEACH-1012
Testing story
Unit tests for controller
Deployment strategy
Follow-up work
Creating the FE component that will call the added endpoints.
Privacy
Security
Authenticating users calling the feedback form are teachers.
Caching
PR Checklist: