Gen AI lab: styling pass #58004
Merged
Gen AI lab: styling pass #58004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
commented
Apr 15, 2024
| @@ -25,22 +25,6 @@ import {AichatLevelProperties, ViewMode} from '@cdo/apps/aichat/types'; | |||
| import {isProjectTemplateLevel} from '@cdo/apps/lab2/lab2Redux'; | |||
| import ProjectTemplateWorkspaceIcon from '@cdo/apps/templates/ProjectTemplateWorkspaceIcon'; | |||
|
|
|||
| const renderChatWorkspaceHeaderRight = (onClear: () => void) => { | |||
There was a problem hiding this comment.
Tired of seeing helpers at the top of React components, so moved to bottom :)
fisher-alice
approved these changes
Apr 15, 2024
| } | ||
|
|
||
| input { | ||
| @extend %full-width; | ||
| height: 30px; | ||
| border-radius: 4px; | ||
| border-color: $lighter_gray; |
There was a problem hiding this comment.
Posted a question about this to @markabarrett on Slack.
There was a problem hiding this comment.
Didn't fully implement the design system for inputs and textareas, but at least switched the outline to match the preferred color ($light_black)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Description
Friday afternoon timeboxed glow up 💅 for gen AI:
textareaandinput, standardize sizes