P20-848: Add error page for unsupported LTI message type #58024
Conversation
artem-vavilov
force-pushed
the
P20-848/better-lti-auth-error
branch
from
a1300b2
to
ad2a586
Compare
dashboard/config/locales/pt-BR.yml
Outdated
There was a problem hiding this comment.
I see changes in Portuguese-PR and Turkish, but we can't see the changes due to Git LFS. Would you mind summing up what changes in those files?
There was a problem hiding this comment.
Removed the unused i18n string lti.error.wrong_resource_type:
https://github.com/code-dot-org/code-dot-org/pull/58024/files#diff-4531be2e4504baa00e047e2d7939bb34b2d7c8aedf31690b31082f0ff66e55bcL1426
| #lti-unsupported-message-type.error-page | ||
| .error-parent | ||
| .error-child | ||
| = image_tag '/shared/images/sad-bee-avatar.png', alt: t('lti.error.unsupported_message_type') |
There was a problem hiding this comment.
I would use an empty alt text for the sad bee since:
- The image does NOT contain text.
- The image is NOT used in a link or a button.
- The image does NOT contribute meaning to the current page or context.
- The alt text is used in the title below.
Given those cases, I would consider the image decorative.
| @@ -692,6 +692,8 @@ module SharedConstants | |||
| INTEGRATION_EARLY_ACCESS_URL: 'https://docs.google.com/forms/d/e/1FAIpQLScjfVR4CZs8Utf5vI4mz3e1q8vdH6RNIgTUWygZXN0oovBSQg/viewform', | |||
| INTEGRATION_BUG_REPORT_URL: 'https://support.code.org/hc/en-us/requests/new?ticket_form_id=14998494738829&tf_23889708=lms_eaf', | |||
| ADDITIONAL_FEEDBACK_URL: 'https://studio.code.org/form/lms_integration_modal_feedback', | |||
| # TODO(P20-873): Replace SUPPORTED_METHODS_URL with the link to the supported methods documentation | |||
There was a problem hiding this comment.
Thanks for creating the jira and leaving a reminder
| @@ -7,6 +7,13 @@ module AccessTokenScopes | |||
| CONTEXT_MEMBERSHIP = 'https://purl.imsglobal.org/spec/lti-nrps/scope/contextmembership.readonly'.freeze | |||
| end | |||
|
|
|||
| module MessageType | |||
| CLAIM = :'https://purl.imsglobal.org/spec/lti/claim/message_type' | |||
| SUPPORTED = [ | |||
There was a problem hiding this comment.
Nice, should be easy to add deep linking message type support later.
Screenshot
Links